Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Fixed Black GitHub action #33

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Jan 12, 2024

Black GitHub action was not working.
There where two Problems:

  • In the regex one "" was missing what lead to a misinterpretation of the regex.
  • The input "args" does not exist and got changed to options.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f01352) 66.58% compared to head (3df032c) 66.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #33   +/-   ##
=======================================
  Coverage   66.58%   66.58%           
=======================================
  Files          13       13           
  Lines         832      832           
=======================================
  Hits          554      554           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VinzentRisch VinzentRisch requested a review from misialq January 12, 2024 16:00
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch, thanks for fixing that! I'm wondering whether we should change the name of this action from "Lint" to "Black" - just to clearly distinguish it from the other lint that is running in parallel - could you update lines 1 and 6? Thanks! This and the small comment in-line aside, feel free to merge afterwards 🙌

.github/workflows/black.yaml Outdated Show resolved Hide resolved
@VinzentRisch VinzentRisch merged commit d7f131c into bokulich-lab:main Jan 16, 2024
6 checks passed
@VinzentRisch VinzentRisch deleted the fix_black_github_action branch January 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants