-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Removed 'move_files' function from 'reads.py' #25
MAINT: Removed 'move_files' function from 'reads.py' #25
Conversation
Hi Santiago, Michal told me to assign PRs also to you to divide the work load better. |
Hey @VinzentRisch. I ❤️ small PRs ;). I'll take a look tmo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
✅ It looks good to me! I just made one style suggestion (deleting a blank line between a comet and its code). I also ran the tests locally and they all passed.
-
👀 TLDR; If you already tried the action out with the modification go ahead and merge!
- In the future it would be nice if your PR message contains a demo on how to run the action that you are modifying so that the reviewer can run it or play around with it, to see that nothing breaks. I would imagine that there is no issue here since you are just moving around already existing functionality.
Thanks :) And yes I will always include it in the future I just thought the changes are so small that you don't have have to try to run it. |
Co-authored-by: Santiago Castro Dau <[email protected]>
This reverts commit 8f4b64f.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 66.74% 66.70% -0.04%
==========================================
Files 13 13
Lines 836 835 -1
==========================================
- Hits 558 557 -1
Misses 278 278 ☔ View full report in Codecov by Sentry. |
move_files
was a helper function ofannotate_reads_card
that moved the files that where created by the analysis, to the allele and gene sample directoriesCARDAnnotationDirectoryFormat
and with this setup it will be easier.