-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Removed visualize-annotation-stats
visualizer because of compatibility issues with altair and pyarrow
#24
CI: Removed visualize-annotation-stats
visualizer because of compatibility issues with altair and pyarrow
#24
Conversation
This reverts commit b60d061.
Hey @VinzentRisch, I think there is only one solution to move this forward (at least for now). Since we cannot solve the environment to make it work, maybe we could (after all) simply remove this visualization action (despite of what we just discussed recently) - it's not really useful right now and it introduces the dependency on Altair. If you are ok with this, I would suggest you to:
Does this make sense? Am I missing something? |
Hi @misialq, I dind't find ay other solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VinzentRisch, I think we can leave it as is - thanks! See the small cosmetic suggestion below + please update it with the changes you merged from the other PR (the black step is not working). After that, feel free to merge 🙌
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
===========================================
+ Coverage 66.58% 93.35% +26.77%
===========================================
Files 13 18 +5
Lines 832 1054 +222
===========================================
+ Hits 554 984 +430
+ Misses 278 70 -208 ☔ View full report in Codecov by Sentry. |
visualize-annotation-stats
visualizer because of compatibility issues with altair and pyarrow
This PR solves #34
visualize-annotations-stats
visualizer and all associated functions from reads.pyvisualize-annotations-stats
from plugin_setup.py and README.md.Now the pyarrow dependency is not a problem anymore because altair was removed.