Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add aligner property to annotate-reads-card outputs #20

Merged
merged 40 commits into from
Jan 16, 2024

Conversation

VinzentRisch
Copy link
Collaborator

-Added properties to the annoate-reads-card action outputs of type SampleData[CARDAlleleAnnotation] and SampleData[CARDGeneAnnotation].
-These properties can be "kma", "bowtie2", "bwa" depending on the aligner parameter used.

@VinzentRisch VinzentRisch requested a review from misialq January 4, 2024 16:21
@VinzentRisch VinzentRisch linked an issue Jan 4, 2024 that may be closed by this pull request
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch, looks good and works as expected 👌

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7f131c) 66.58% compared to head (9d1e7c1) 66.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   66.58%   66.62%   +0.04%     
==========================================
  Files          13       13              
  Lines         832      833       +1     
==========================================
+ Hits          554      555       +1     
  Misses        278      278              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VinzentRisch VinzentRisch merged commit c0ca96d into bokulich-lab:main Jan 16, 2024
6 checks passed
@VinzentRisch VinzentRisch deleted the add_property_reads_output branch January 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Add aligner property to annotate-reads-card outputs
3 participants