Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added FeatureTable[Frequency] output to annotate-reads-card function #12

Conversation

VinzentRisch
Copy link
Collaborator

  • Added FeatureTable[Frequency] output to annotate-reads-card function
  • Changed the way count tables are created in annotate-reads-card and annotate-mags-card function

@VinzentRisch VinzentRisch requested a review from misialq December 11, 2023 10:34
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch, I tried it out and it ran as expected 🚀 See some small in-line comments below. Otherwise, you should also update the output descriptions in plugin_setup.py: right now they say that you are generating a presence-absence table which is no longer true.

q2_amr/tests/card/test_utils.py Outdated Show resolved Hide resolved
q2_amr/tests/card/test_utils.py Outdated Show resolved Hide resolved
@VinzentRisch VinzentRisch requested a review from misialq January 4, 2024 09:18
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4c837da) 66.58% compared to head (34ae96e) 66.74%.

Files Patch % Lines
q2_amr/card/utils.py 14.28% 6 Missing ⚠️
q2_amr/card/reads.py 0.00% 2 Missing ⚠️
q2_amr/card/mags.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   66.58%   66.74%   +0.15%     
==========================================
  Files          13       13              
  Lines         838      836       -2     
==========================================
  Hits          558      558              
+ Misses        280      278       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! :shipit:

@VinzentRisch VinzentRisch merged commit 1729fb5 into bokulich-lab:main Jan 4, 2024
5 checks passed
@VinzentRisch VinzentRisch deleted the frequency_table_branched_from_main branch January 4, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants