-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added FeatureTable[Frequency] output to annotate-reads-card function #12
ENH: Added FeatureTable[Frequency] output to annotate-reads-card function #12
Conversation
VinzentRisch
commented
Dec 8, 2023
- Added FeatureTable[Frequency] output to annotate-reads-card function
- Changed the way count tables are created in annotate-reads-card and annotate-mags-card function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VinzentRisch, I tried it out and it ran as expected 🚀 See some small in-line comments below. Otherwise, you should also update the output descriptions in plugin_setup.py
: right now they say that you are generating a presence-absence table which is no longer true.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 66.58% 66.74% +0.15%
==========================================
Files 13 13
Lines 838 836 -2
==========================================
Hits 558 558
+ Misses 280 278 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!