MAINT: Remove all functionality for AMRFinderPlus #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b661340.
…okulich-lab#88)" This reverts commit 41bae5e.
…e called `fetch_amrfinderplus_db` (bokulich-lab#82)" This reverts commit 38e48b5.
…tionsDirFmt (bokulich-lab#92)" This reverts commit d785a0e.
This reverts commit 0b5439a.
This reverts commit fb9e4b5.
|
Hi @misialq |
|
Unfortunately, I have seen this in moshpit as well and as of today I have no clue what the problem is 😅 |
misialq
reviewed
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #105
Reverts all these commits:
"ENH: add new type
AMRFinderPlusDatabase#81""ENH: add
AMRFinderPlusAnnotationtype #86""BUG: added database_format_version.txt to AMRFinderPlusAnnotationsDirFmt #92"
"ENH: Added new action that can download AMRFinderPlus database called
fetch_amrfinderplus_db#82""ENH: Action to annotate MAGs and contigs with AMRFinderPlus #88"
"ENH: Removed
AMRFinderPlusAnnotationtype #95""ENH: Add three new parameters to run_amrfinderplus_n #97"
All this functionality was moved to q2-amrfinderplus.