Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF: Refactor utils #101

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Jul 25, 2024

solves #99

  • Added new utils and test_utils that house all actions that are used by card and amrfinderplus subpackages.
  • Refactor of all transformers to metadata to make it easier to create transformers for amrfinderplus formats.
  • Added create_df and combine_dataframes that get used by all transformers to metadata.
  • Removed own test plugin base in card/types/tests/test_types_formats_transformers.py and replaced with base from qiime.

Set up an environment

https://github.com/bokulich-lab/q2-amr?tab=readme-ov-file#installation

Run it locally

  1. First, clone the repo and checkout the PR branch:
git clone https://github.com/bokulich-lab/q2-amr.git
cd q2-amr
git fetch origin pull/101/head:pr-101
git checkout pr-101
pip install -e .

@VinzentRisch VinzentRisch requested review from a team and misialq and removed request for a team July 25, 2024 13:37
@VinzentRisch VinzentRisch marked this pull request as draft September 27, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant