Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: test_draw_busco_plots_for_render is altair version variant #83

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Sann5
Copy link
Contributor

@Sann5 Sann5 commented Oct 16, 2023

Closes #81

In busco/tests/test_utils.py the test_draw_busco_plots_for_render function compares two dictionaries. Some of the entries in this dictionary change depending on the version of altair that is being used. I removed and edited these version-dependent keys to bypass the test failure. The rest of the dictionary is still compared.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #83 (da37e9a) into main (70afdfa) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   97.58%   97.59%   +0.01%     
==========================================
  Files          32       32              
  Lines        1945     1954       +9     
==========================================
+ Hits         1898     1907       +9     
  Misses         47       47              
Files Coverage Δ
q2_moshpit/busco/tests/test_utils.py 95.52% <100.00%> (+0.20%) ⬆️
q2_moshpit/kraken2/classification.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks @Sann5! 🥇

@misialq misialq merged commit 89ca6e2 into bokulich-lab:main Oct 17, 2023
7 checks passed
@Sann5 Sann5 deleted the issue_81 branch February 27, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting local BUSCO test failure
2 participants