Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add action to fetch Kaiju DBs #61

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Sep 6, 2023

@misialq misialq marked this pull request as ready for review November 10, 2023 16:05
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #61 (3ce7c26) into main (01db060) will increase coverage by 0.05%.
The diff coverage is 98.55%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   97.69%   97.74%   +0.05%     
==========================================
  Files          32       35       +3     
  Lines        2038     2172     +134     
==========================================
+ Hits         1991     2123     +132     
- Misses         47       49       +2     
Files Coverage Δ
q2_moshpit/__init__.py 100.00% <100.00%> (ø)
q2_moshpit/kaiju/__init__.py 100.00% <100.00%> (ø)
q2_moshpit/kaiju/database.py 100.00% <100.00%> (ø)
q2_moshpit/plugin_setup.py 100.00% <100.00%> (ø)
q2_moshpit/kaiju/tests/test_database.py 96.96% <96.96%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@misialq misialq requested a review from VinzentRisch November 13, 2023 13:22
Copy link
Contributor

@VinzentRisch VinzentRisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.
I ran the method with plasmids, viruses and fungi and all work with no problems.
Progress bar works too and is actually really useful i should add that to fetch-card-db in q2-amr.

@misialq misialq merged commit 0668991 into bokulich-lab:main Nov 21, 2023
7 checks passed
@misialq misialq deleted the issue-41-fetch-kaiju branch November 21, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add action to fetch Kaiju indices
2 participants