generated from bokulich-lab/q2-plugin-template
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes incomplete extraction of sample ids from filenames #28
Closed
gregcaporaso
wants to merge
49
commits into
bokulich-lab:main
from
gregcaporaso:file-name-assumption
Closed
fixes incomplete extraction of sample ids from filenames #28
gregcaporaso
wants to merge
49
commits into
bokulich-lab:main
from
gregcaporaso:file-name-assumption
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: binarytextfile format to store reference database. Rewire. Possibly multifile directory format and chose between name based on the type of reference being created. Change subprocess stdout and stderr to PIPE so that errors from there are captured by QIIME 2's logging machinery.
TODO next time, figure out why not downloader not raising errror when given mixed taxa types
add --dbmem parameter to address issue with very long runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #27