Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add filter-kraken-reports #212

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ENH: Add filter-kraken-reports #212

wants to merge 7 commits into from

Conversation

VinzentRisch
Copy link
Contributor

@VinzentRisch VinzentRisch commented Oct 21, 2024 •
edited by misialq
Loading

Closes #209
Depends on qiime2/q2-types#347

New action that can filter Kraken reports and outputs by metadata and also remove empty kraken reports.

@VinzentRisch
Copy link
Contributor Author

VinzentRisch commented Oct 21, 2024 •
edited
Loading

Hi @misialq
I have a question.
I saw examples of empty (unclassified) reports in the moshpit test data and my criteria for an empty report is if the report has exactly one line and if in the 6th column it says either root or unclassified. like this:
100.00 229 17 R 1 root
100.00 229 229 U 0 unclassified
Are these criteria correct or did I miss something?

@VinzentRisch VinzentRisch requested a review from misialq October 21, 2024 13:28
@VinzentRisch VinzentRisch changed the title ENH: Added filter-kraken-report-output ENH: Added filter-kraken-reports Oct 24, 2024
@misialq
Copy link
Contributor

misialq commented Nov 1, 2024

Hey @VinzentRisch, yeah, I think that is a correct assumption.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

This PR/issue depends on:

@misialq misialq changed the title ENH: Added filter-kraken-reports ENH: Add filter-kraken-reports Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misialq misialq Awaiting requested review from misialq

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: add action to filter Kraken reports
2 participants
@VinzentRisch @misialq