ENH: allow fetching 16S DBs by build-kraken-db
#134
Conversation
There was a problem hiding this comment.
Hey @DorielaGrabocka, I tried it and all seems to work - see some suggestions below though 😄
.gitignore
Outdated
| **/*.ipynb | ||
|
|
||
| # Ignore parsl dir | ||
| # Byte-compiled / optimized / DLL files |
There was a problem hiding this comment.
The contents of this file seems the same so I'm guessing the line separators must have changed... Could you please revert that?
There was a problem hiding this comment.
This is a bit weird, locally I cannot see any changes. It does not detect anything. maybe after my commit it will be ok?
There was a problem hiding this comment.
Hey @DorielaGrabocka, please just revert that file to what it was before - you can do so e.g. by checking out that single file from the main branch and then re-commiting.
misialq
changed the title
build-kraken-db
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 97.74% 97.77% +0.02%
==========================================
Files 45 53 +8
Lines 2799 3141 +342
==========================================
+ Hits 2736 3071 +335
- Misses 63 70 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey @DorielaGrabocka, that looks good! I gave it a final try and all worked as expected. Please just see one small comment about that gitignore file. Otherwise, feel free to merge afterwards :)
.gitignore
Outdated
| **/*.ipynb | ||
|
|
||
| # Ignore parsl dir | ||
| # Byte-compiled / optimized / DLL files |
There was a problem hiding this comment.
Hey @DorielaGrabocka, please just revert that file to what it was before - you can do so e.g. by checking out that single file from the main branch and then re-commiting.
| @parameterized.expand([ | ||
| ("kraken/tmp/16S_Greengenes13.5.tgz", | ||
| "16S_Greengenes13.5.tgz", | ||
| "16S_Greengenes13.5", | ||
| "/tmp/16S_Greengenes13.5/", | ||
| "greengenes"), | ||
| ("kraken/tmp/16S_RDP11.5_20200326.tgz", | ||
| "16S_RDP11.5_20200326.tgz", | ||
| "16S_RDP_k2db", | ||
| "/tmp/16S_RDP_k2db/", | ||
| "rdp"), | ||
| ("kraken/tmp/16S_Silva132_20200326.tgz", | ||
| "16S_Silva132_20200326.tgz", | ||
| "16S_SILVA132_k2db", | ||
| "/tmp/16S_SILVA132_k2db/", | ||
| "silva132"), | ||
| ("kraken/tmp/16S_Silva138_20200326.tgz", | ||
| "16S_Silva138_20200326.tgz", | ||
| "16S_SILVA138_k2db", | ||
| "/tmp/16S_SILVA138_k2db/", | ||
| "silva138" | ||
| ), | ||
| ]) |
There was a problem hiding this comment.
Woooow, that's what I was talking about! 🚀
Added support for 4 16S databases.
Closes #92.