Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more types genomics #133

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

Oddant1
Copy link
Contributor

@Oddant1 Oddant1 commented Feb 13, 2024

Change types_genomics to types in accordance with qiime2/q2-types#309

Blocked by qiime2/q2-types#309

Copy link
Contributor

@lizgehret lizgehret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all lgtm. same comment as w/the other two PRs - once i test this locally, i'll get the blocking types PR merged and then we can re-run CI on this for a final check.

Copy link

@lizgehret
Copy link
Contributor

Failure explained here. Running a new shotgun Prepare will fix this; will re-run CI again afterwards which should then be successful.

@nbokulich
Copy link
Contributor

Merging this to resolve the chicken-vs-egg problem re: metapackage build. See bokulich-lab/q2-assembly#71 (comment)

@nbokulich nbokulich merged commit 1677131 into bokulich-lab:main Feb 15, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants