-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep: install checkm and pplacer via conda #13
Conversation
@misialq - this PR is a start for getting a pure-conda recipe in order. Unfortunately you'll have to sort out getting a functional pplacer build for macos. It looks like there has been a bit of churn on this topic over at bioconda/bioconda-recipes. |
Yeah it also looks like very few have even attempted a source build, which is actually pretty odd for bioconda. I'm going to see if I can get such a recipe to work, and then a lot of that mess ought to be solved. |
Thanks for looking into that @thermokarst and @ebolyen! 🙇 |
So some bad news: I have half of a recipe that might work, except for a downstream dependency issue in pplacer itself. But I think the worse headline news is, this package cannot actually be compiled except by a handful of developers who happen to have this ancient version in their opam cache. Worse, we shouldn't expect any meaningful updates as pplacer is no longer developed or maintained. I might be able to work around these things, but we'd be mocking out ancient versions of things to resuscitate a package that is already quite dead. Does it make sense to go through that? Given the dependency on pplacer through CheckM, it seems like there may be a need for some kind of |
It looks like epa-ng might be a viable alternative, although that just pushes the issue up to CheckM. |
Oh my, what a, pardon me, mess... 😭 Thanks for going through that @ebolyen! I discussed today with @nbokulich, and we both feel like this is way too much work for it to be worth it... We've had enough trouble with CheckM already (like python 3.8 compatibility issues, or the outdated DB) - let's not invest more effort into that. We are thinking that instead of doing that, we could put CheckM into its own, separate plugin which would not become part of the Library - that way we can keep those dependencies separate, install pplacer the way it is now being installed and be done with it. Instead we could invest time into integrating some more modern QC evaluation tools into moshpit (e.g. we have discussed BUSCO). What do you think? |
No description provided.