-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: allow SampleData[MAGs] as input to eggnog-diamond-search
and classify-kraken2
#125
Conversation
951e01a
to
8785464
Compare
8785464
to
8d081b4
Compare
Hey @gregcaporaso, do you think someone from your team could have a look/test this (particularly the Kraken2 part)? 🙏 |
This PR/issue depends on: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
+ Coverage 97.74% 97.82% +0.07%
==========================================
Files 64 64
Lines 3415 3534 +119
==========================================
+ Hits 3338 3457 +119
Misses 77 77 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Michal! I all looks good to me. I already made some stand alone comments. As general suggestion I think I would have prefered if this was two PRs (one per action), but I imagine maybe you had a reason for doing them together.
- ✅ I tries the actions with some
SampleData[MAGs]
artifacts and it all works smoothly. ⚠️ All tests pass individually but when I run the whole test suite together I get error in ~12 tests for having too many files open. I think this is rather a limitation of my personal computer since this does not come up in the CI (or your own machine I suppose). Even so, this might prove annoying in the future for developers with weak computers like mine.
Hey @Sann5, thanks for your review! The behaviour you described, though, seems very strange - I never saw any of that when running the tests locally. Also, I don't see how this should happen as all the tests should be running one-by-one and things should get cleaned up between those runs. Could you provide more details as to that behaviour?:
Thanks! I'll merge this regardless as this should not be related to that PR but it would be nice if you could share some more details 🙏 |
Closes #110.
Closes #112.
Depends on qiime2/q2-types#311.
Some sample MAGs can be found here and dereplicated MAGs here.