Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: allow SampleData[MAGs] as input to eggnog-diamond-search and classify-kraken2 #125

Merged
merged 21 commits into from
May 10, 2024

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jan 25, 2024

Closes #110.
Closes #112.
Depends on qiime2/q2-types#311.

Some sample MAGs can be found here and dereplicated MAGs here.

@misialq misialq force-pushed the allow-more-mag-inputs branch from 8785464 to 8d081b4 Compare January 25, 2024 14:35
@misialq misialq marked this pull request as ready for review January 29, 2024 17:40
@misialq
Copy link
Contributor Author

misialq commented Jan 29, 2024

Hey @gregcaporaso, do you think someone from your team could have a look/test this (particularly the Kraken2 part)? 🙏

q2_moshpit/plugin_setup.py Outdated Show resolved Hide resolved
@misialq misialq requested a review from VinzentRisch February 5, 2024 14:24
@Sann5 Sann5 self-requested a review February 5, 2024 17:20
q2_moshpit/plugin_setup.py Outdated Show resolved Hide resolved
Copy link

@misialq misialq self-assigned this Mar 14, 2024
@misialq misialq added the enhancement New feature or request label Mar 14, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (2b3b03d) to head (3ef2ed9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   97.74%   97.82%   +0.07%     
==========================================
  Files          64       64              
  Lines        3415     3534     +119     
==========================================
+ Hits         3338     3457     +119     
  Misses         77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@misialq misialq requested a review from Sann5 May 3, 2024 08:05
Copy link
Contributor

@Sann5 Sann5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michal! I all looks good to me. I already made some stand alone comments. As general suggestion I think I would have prefered if this was two PRs (one per action), but I imagine maybe you had a reason for doing them together.

  • ✅ I tries the actions with some SampleData[MAGs] artifacts and it all works smoothly.
  • ⚠️ All tests pass individually but when I run the whole test suite together I get error in ~12 tests for having too many files open. I think this is rather a limitation of my personal computer since this does not come up in the CI (or your own machine I suppose). Even so, this might prove annoying in the future for developers with weak computers like mine.

@misialq
Copy link
Contributor Author

misialq commented May 10, 2024

Hey @Sann5, thanks for your review! The behaviour you described, though, seems very strange - I never saw any of that when running the tests locally. Also, I don't see how this should happen as all the tests should be running one-by-one and things should get cleaned up between those runs. Could you provide more details as to that behaviour?:

  • is it always the same set of tests?
  • which files would those tests be using?
  • how exactly are you running those?

Thanks! I'll merge this regardless as this should not be related to that PR but it would be nice if you could share some more details 🙏

@misialq misialq merged commit 06a920b into bokulich-lab:main May 10, 2024
9 checks passed
@misialq misialq deleted the allow-more-mag-inputs branch May 10, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants