ENH: add action to collate genomes to GenomeData[DNASequences] #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 98.32% 98.39% +0.07%
==========================================
Files 39 39
Lines 2631 2748 +117
==========================================
+ Hits 2587 2704 +117
Misses 44 44 ☔ View full report in Codecov by Sentry. |
misialq
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Hey @DorielaGrabocka, can you please rebase this branch on top of main? The changes here should not have anything to do with the changes from the other PR, right? It's a completely independent action.
DorielaGrabocka
force-pushed
the
issue-97-feature-data-to-genome-data
branch
from
217e2bb to
d895f92
Compare
DorielaGrabocka
force-pushed
the
issue-97-feature-data-to-genome-data
branch
from
d98f67c to
c72d5e9
Compare
misialq
reviewed
Aug 28, 2024
DorielaGrabocka
force-pushed
the
issue-97-feature-data-to-genome-data
branch
from
bc188d7 to
1bc46f6
Compare
misialq
changed the title
misialq
previously approved these changes
Aug 29, 2024
misialq
reviewed
Aug 29, 2024
misialq
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Hey @DorielaGrabocka, sorry to un-approve but I just had another look and realized that your tests actually need a bit more work - please see the comment below.
misialq
requested changes
Sep 3, 2024
misialq
reviewed
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #97