Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add 'filter-contigs' action #92

Merged
merged 10 commits into from
Jan 14, 2025
Merged

Conversation

misialq
Copy link
Contributor

@misialq misialq commented Jul 12, 2024

Closes #91.
Closes #84.

@misialq misialq marked this pull request as draft July 12, 2024 08:49
@misialq misialq requested a review from VinzentRisch October 14, 2024 07:44
Copy link
Contributor

@VinzentRisch VinzentRisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michal
The actions needs a validation step that checks if the parameter combination is allowed.

  • The action can be run without any parameter what will just copy the artifact without any filtering. I think there should rather be an error message.
  • I can use the action without the metadata parameter but with the where parameter. How I understand it, the where parameter then has no effect. This should also lead to an error.

q2_assembly/_action_params.py Outdated Show resolved Hide resolved
@misialq misialq requested a review from Copilot November 19, 2024 20:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.

@misialq misialq marked this pull request as ready for review January 9, 2025 12:50
@misialq misialq requested a review from VinzentRisch January 9, 2025 12:50
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 97.19626% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.28%. Comparing base (fda616a) to head (ed4723b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
q2_assembly/filter/filter.py 94.54% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   98.32%   98.28%   -0.05%     
==========================================
  Files          38       41       +3     
  Lines        2745     2851     +106     
==========================================
+ Hits         2699     2802     +103     
- Misses         46       49       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@VinzentRisch VinzentRisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi everything looks good! I just found a typo in one error message.

q2_assembly/filter/filter.py Outdated Show resolved Hide resolved
@misialq misialq requested a review from VinzentRisch January 14, 2025 11:15
Copy link
Contributor

@VinzentRisch VinzentRisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@misialq misialq merged commit 509401a into bokulich-lab:main Jan 14, 2025
9 checks passed
@misialq misialq deleted the filter-contigs branch January 14, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: filter contigs by length ENH: add an action to filter SampleData[Contigs]
2 participants