-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add 'filter-contigs' action #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Michal
The actions needs a validation step that checks if the parameter combination is allowed.
- The action can be run without any parameter what will just copy the artifact without any filtering. I think there should rather be an error message.
- I can use the action without the metadata parameter but with the where parameter. How I understand it, the where parameter then has no effect. This should also lead to an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Co-authored-by: VinzentRisch <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 98.32% 98.28% -0.05%
==========================================
Files 38 41 +3
Lines 2745 2851 +106
==========================================
+ Hits 2699 2802 +103
- Misses 46 49 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi everything looks good! I just found a typo in one error message.
Co-authored-by: VinzentRisch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #91.
Closes #84.