Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/DEP: update recipe and add quast #20

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

ebolyen
Copy link
Contributor

@ebolyen ebolyen commented Jun 15, 2022

Testing my theory in #16 (comment).

Also some super minor changes to the recipe to match our current build-process a bit better.

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #20 (236072d) into main (d88013e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files           7        7           
  Lines         356      356           
  Branches       60       60           
=======================================
  Hits          344      344           
  Misses          7        7           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88013e...236072d. Read the comment docs.

@ebolyen
Copy link
Contributor Author

ebolyen commented Jun 15, 2022

Ah, still no py38 builds for quast. I guess it's never that easy.

Strange that bioconda didn't just build those automatically though.

@ebolyen
Copy link
Contributor Author

ebolyen commented Jun 15, 2022

And this would be the reason:
https://github.com/bioconda/bioconda-recipes/blob/master/recipes/quast/meta.yaml#L10-L12

Looks like the recipe can probably be updated:
ablab/quast@bc4af76

A robot did the last update, so it wouldn't have known:
bioconda/bioconda-recipes#35252

@ebolyen
Copy link
Contributor Author

ebolyen commented Jun 15, 2022

Hopefully there will be a 3.8 build soonish: bioconda/bioconda-recipes#35385

@ebolyen
Copy link
Contributor Author

ebolyen commented Jun 16, 2022

Done!

@ebolyen ebolyen requested a review from misialq June 16, 2022 16:41
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ebolyen, this is great - thanks for investigating and for the changes!

@ebolyen
Copy link
Contributor Author

ebolyen commented Jun 16, 2022

Awesome, this should be ready for merge then.

@misialq misialq merged commit f294746 into bokulich-lab:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants