ENH: add 'filter-contigs' action #92
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinzentRisch
requested changes
Oct 15, 2024
There was a problem hiding this comment.
Hey Michal
The actions needs a validation step that checks if the parameter combination is allowed.
- The action can be run without any parameter what will just copy the artifact without any filtering. I think there should rather be an error message.
- I can use the action without the metadata parameter but with the where parameter. How I understand it, the where parameter then has no effect. This should also lead to an error.
| "criteria that must be met to be included in the filtered " | ||
| "data. If not provided, all samples in `metadata` that are " | ||
| "also in the contig data will be retained.", | ||
| "exclude_ids": "Defaults to False. If True, the samples selected by " |
There was a problem hiding this comment.
Suggested change
| "exclude_ids": "Defaults to False. If True, the samples selected by " | |
| "exclude_ids": "If True, the samples selected by " |
Default is already displayed
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91.
Closes #84.