Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add kraken2-inspect action #95

Merged
merged 5 commits into from
Nov 29, 2023
Merged

ENH: add kraken2-inspect action #95

merged 5 commits into from
Nov 29, 2023

Conversation

colinvwood
Copy link
Contributor

No description provided.

@colinvwood
Copy link
Contributor Author

colinvwood commented Nov 13, 2023 •
edited
Loading

blocked by bokulich-lab/q2-types-genomics#62

@colinvwood colinvwood marked this pull request as ready for review November 14, 2023 18:09
misialq
misialq reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@misialq misialq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @colinvwood! I tried it out with a small database - worked all good. Approval waiting for the CI to pass 😆

q2_moshpit/plugin_setup.py Outdated Show resolved Hide resolved
@colinvwood colinvwood changed the title add kraken2-inspect action ENH: add kraken2-inspect action Nov 17, 2023
@gregcaporaso
Copy link
Contributor

gregcaporaso commented Nov 27, 2023 •
edited
Loading

I don't need to review this one if @misialq is reviewing, unless you all specifically want my feedback. Just reassign me if that's the case.

Thanks @misialq and @colinvwood!

@gregcaporaso gregcaporaso removed their request for review November 27, 2023 21:17
misialq
misialq approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @colinvwood, LGTM - thanks! 🙏 I'm merging this one.

@misialq misialq merged commit f695683 into bokulich-lab:main Nov 29, 2023
3 of 5 checks passed
@colinvwood colinvwood mentioned this pull request Dec 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misialq misialq misialq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinvwood @gregcaporaso @misialq