ENH: added --p-max-seq-len to extract-seq-segments and associated test code
#209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikerobeson
changed the title
--p-max-seq-len extract-seq-segments to and test code--p-max-seq-len extract-seq-segments and test code
mikerobeson
changed the title
--p-max-seq-len extract-seq-segments and test code--p-max-seq-len to extract-seq-segments and associated test code
VinzentRisch
suggested changes
Nov 19, 2024
There was a problem hiding this comment.
Hi @mikerobeson
Everything looks good to me, except for one suggestion below.
|
Hi @VinzentRisch, I've incorporated your suggestions. Thank you so much for the review! :-) |
VinzentRisch
approved these changes
Nov 19, 2024
|
Merging and this PR based on comments from @VinzentRisch. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to
qiime rescript extract-seq-segments:--p-max-seq-len: to prevent long reference segment sequences to be used for searching.test_extract_seq_segments_min_max: tests setting--min-seq-len&--max-seq-lenreference segment sequences.