Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Added ranks and rank-propagation parameters to get-ncbi-genomes #207

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

VinzentRisch
Copy link
Contributor

solves #194

  • Added ranks and rank-propagation parameters to get-ncbi-genomes.
  • The parameters behave the same as in the get-ncbi-data function

@mikerobeson mikerobeson merged commit 0091c79 into bokulich-lab:master Oct 23, 2024
4 checks passed
@nbokulich
Copy link
Collaborator

hey @mikerobeson just to confirm since I did not see any review comments before you merged: everything checks out with rank propagation and custom ranks?

@mikerobeson
Copy link
Collaborator

Hi @nbokulich, I entered in my comments in the merge dialog... I guess that did not take? But yes, rank propagation worked as well as selecting different rank options. I also checked the lint and test cases.. all passed.

@nbokulich
Copy link
Collaborator

hey @mikerobeson no it looks like these were hidden. Thanks for testing and confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants