-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMP: replace volatility with lineplot for evaluate_*
visualizers
#204
Conversation
This is now currently hooked up and working for Note regarding CI failures: RESCRIPt can't currently be built because it doesn't know what vizard is. I'll address this once the functionality is working (as vizard just needs to be added to the amplicon distro in order to resolve this). |
Changes in lineplot have been implemented (merged PR here), and this is all working as expected! I tested this using the data provided in the RESCRIPt tutorial, and the results look essentially identical (just with slightly different visual scaling). |
@nbokulich would you mind reviewing this when you get the chance? 🙂 Actual code changes are very minimal, so mainly just user testing to make sure the updated visualizations look as you'd expect. |
Test failure has been addressed - now that the output of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice way to refactor this so that we are still testing the validation.
@nbokulich do you want to take a glance at this before I merge? |
Hey @nbokulich sorry to keep bugging you! Most of us will be at a conference all of next week, so I'm hoping to get all PRs merged by EOW in preparation for the release. Could you let me know if you have any thoughts/feedback before then? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the reminder @lizgehret , got tied up with teaching stuff last week.
I tested with a few different databases to do a side-by-side comparison with the new viz. Looks great!
Closes qiime2/q2-vizard#32
This PR will replace the use of
longitudinal volatility
with the new lineplot that's now available within q2-vizard. The following visualizers will receive this replacement: