Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: refactor GTDB taxonomy parser #192

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

nbokulich
Copy link
Collaborator

Refactoring the taxonomy parser to be more robust to possible intrusion of whitespace chars in the future. Thanks for the suggestion @ebolyen !

@nbokulich nbokulich requested a review from misialq June 11, 2024 11:00
@misialq misialq changed the title refactor GTDB taxonomy parser MAINT: refactor GTDB taxonomy parser Jun 11, 2024
Copy link
Contributor

@misialq misialq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbokulich nbokulich merged commit 3c179ca into bokulich-lab:master Jun 12, 2024
4 checks passed
lizgehret pushed a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants