BUG: gtdb taxonomy parser #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misialq
approved these changes
Jun 7, 2024
|
is it worth patching the latest release? @lizgehret ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evidently #169 introduced a bug into the way taxonomy is parsed from GTDB files. Taxonomy labels were being split on whitespace, so only the genus name was listed under the species rank.
This fixes this issue by also including the species label, and introduces a simple test for the parser, just in case the taxonomy format changes in the future.
I manually tested and confirmed that this works with versions 202, 214, 220. The taxonomy format is consistent — see the test for the structure.
FYI @mikerobeson