This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Migrate Routes To App Router #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LarsSelbekk
suggested changes
Jul 1, 2024
LarsSelbekk
suggested changes
Jul 2, 2024
LarsSelbekk
reviewed
Jul 2, 2024
LarsSelbekk
suggested changes
Jul 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turned out to be a bit more chonky than I foresaw....
However, this PR migrates us to the latest and greatest in the world of Next js. Now all routes are on the app router! 💯
I switched out Redux with Zustand for simplicity, seems like it is what the cool kids use these days. We might discuss the global state handling at a later stage.
The big thing here is that I have deleted a lot or dead code. A few years ago i coded up some ugly meant-to-be replacements for bl-web stuff. However, most of that is terrible terrible code, and even worse design. Therefore, I just opted to chuck it, as I want to rewrite it all when we actually want to prod those pages. I kept what seemed nice, and put it under the "under-construction" route. From there, we can move them out when we feel ready to move them into production.
This PR is super chonky, so I would mainly appreciate it if you helped test the info and /matches routes, as these are the only ones currently in production.