This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
feat(scanner): immediately refresh match on scan #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
LarsSelbekk
force-pushed
the
speed-up-scanner
branch
from
07cdb42 to
e722af9
Compare
Improve the time from scanning until the match visually updating by immediately refreshing from the API on succesful scan. Would be even faster to optimistically update the local cache of the date, but that's harder and not really necessary. Also rate limited the API transfer call to 4x per second as the API did not handle races well, leading to some cases of multiple customerItems active at the same time for one item, which caused a "not active" error in the scanner as number active == 1 is an assert in the API.
LarsSelbekk
force-pushed
the
speed-up-scanner
branch
from
e722af9 to
8009c98
Compare
|
Guccigucci. I mean it worked pretty flawlessly, so no need to adjust things here ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the time from scanning until the match visually updating by
immediately refreshing from the API on succesful scan. Would be even
faster to optimistically update the local cache of the date, but that's
harder and not really necessary.
Also rate limited the API transfer call to 4x per second as the API did
not handle races well, leading to some cases of multiple customerItems
active at the same time for one item, which caused a "not active" error
in the scanner as number active == 1 is an assert in the API.