Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

fix(BranchInfo): sort OpeningHours & hide deleted #424

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

LarsSelbekk
Copy link
Contributor

There is a bug where bladmin only deletes the references to OpeningHours in the branch, and not the OpeningHours themselves, which is what is queried. Until the bladmin bug is fixed, this hides OpeningHours which are not referenced from the branch.

There is a bug where bladmin only deletes the references to OpeningHours in the branch, and not the
OpeningHours themselves, which is what is queried. Until the bladmin bug is fixed, this hides
OpeningHours which are not referenced from the branch.
@LarsSelbekk LarsSelbekk added the bug Something isn't working label Jan 16, 2024
@LarsSelbekk LarsSelbekk self-assigned this Jan 16, 2024
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bl-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 0:43am

@LarsSelbekk
Copy link
Contributor Author

Copy link

cypress bot commented Jan 16, 2024

8 failed tests on run #177 ↗︎

8 12 0 11 Flakiness 0

Details:

Merge fedeccd into ad28ed9...
Project: bl-next Commit: e7d018a4b1 ℹ️
Status: Failed Duration: 02:41 💡
Started: Jan 16, 2024 12:49 AM Ended: Jan 16, 2024 12:52 AM
Failed  settings.spec.js • 1 failed test • UI - Electron

View Output Video

Test Artifacts
Settings page > displays correct inital elements Screenshots Video
Failed  forgot.spec.js • 1 failed test • UI - Electron

View Output Video

Test Artifacts
Forgot password > can navigate to and from forgot page Screenshots Video
Failed  register.spec.js • 1 failed test • UI - Electron

View Output Video

Test Artifacts
Register > displays correct initial elements Screenshots Video
Failed  login.spec.js • 1 failed test • UI - Electron

View Output Video

Test Artifacts
Login > displays all important elements Screenshots Video
Failed  info.spec.js • 3 failed tests • UI - Electron

View Output Video

Test Artifacts
Info pages > as a customer > displays qna Screenshots Video
Info pages > as a customer > displays buyback list Screenshots Video
Info pages > as a customer > displays contact info Screenshots Video

The first 5 failed specs are shown, see all 6 specs in Cypress Cloud.

Review all test suite changes for PR #424 ↗︎

Copy link
Member

@AdrianAndersen AdrianAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet bugfix 💯

@AdrianAndersen AdrianAndersen merged commit 8fc0c7a into main Jan 16, 2024
8 of 13 checks passed
@AdrianAndersen AdrianAndersen deleted the fix-opening-hours-sort-and-deleted branch January 16, 2024 08:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants