-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against latest Ruby and Rails #326
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,5 +10,5 @@ wiki | |
.ruby-version | ||
.ruby-gemset | ||
Gemfile.lock | ||
gemfiles/*.gemfile.lock | ||
tmp | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
appraise "rails-6.1" do | ||
group :development do | ||
gem "rails", "~> 6.1.0" | ||
end | ||
end | ||
|
||
appraise "rails-7.0" do | ||
group :development do | ||
gem "rails", "~> 7.0.0" | ||
end | ||
end | ||
|
||
appraise "rails-7.1" do | ||
group :development do | ||
gem "rails", "~> 7.1.0" | ||
end | ||
end | ||
|
||
appraise "rails-7.2" do | ||
group :development do | ||
gem "rails", "~> 7.2.0" | ||
gem "sqlite3", "~> 2.0.0" | ||
group :mongo do | ||
gem "mongoid", github: "mongodb/mongoid" | ||
end | ||
end | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# Contributing to Datagrid | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this file somehow reachable from github UI? If not, I think it is better to make it a paragraph in Readme or at least link it from there. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The guidelines should be visible when creating an issue or pull request:
|
||
|
||
## Issues | ||
|
||
Please use GitHub issues for bug reports and feature suggestions. | ||
|
||
## Development | ||
|
||
### Testing | ||
|
||
Tests can be run against different versions of Rails: | ||
|
||
**Using appraisals (recommended)** | ||
|
||
``` shell | ||
# Install the dependencies for each appraisal | ||
bundle install | ||
bundle exec appraisal install | ||
|
||
# Run tests against Rails 7.2 | ||
bundle exec appraisal rails-7.2 rake | ||
|
||
# Run tests against Rails 6.1 | ||
bundle exec appraisal rails-6.1 rake | ||
``` | ||
|
||
**Using BUNDLE_GEMFILE** | ||
|
||
``` shell | ||
# Run tests against Rails 7.2 | ||
BUNDLE_GEMFILE=gemfiles/rails_7.2.gemfile bundle install | ||
BUNDLE_GEMFILE=gemfiles/rails_7.2.gemfile bundle exec rake | ||
|
||
# Run tests against Rails 6.1 | ||
BUNDLE_GEMFILE=gemfiles/rails_6.1.gemfile bundle install | ||
BUNDLE_GEMFILE=gemfiles/rails_6.1.gemfile bundle exec rake | ||
``` |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
group :development do | ||
gem "appraisal" | ||
gem "bump" | ||
gem "csv" | ||
gem "nokogiri" | ||
gem "pry-byebug" | ||
gem "rspec" | ||
gem "sequel" | ||
gem "sqlite3", "~> 1.7.0" | ||
gem "rails", "~> 6.1.0" | ||
|
||
group :mongo do | ||
gem "bson" | ||
gem "mongoid", "~> 9.0" | ||
end | ||
end | ||
|
||
gemspec path: "../" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
group :development do | ||
gem "appraisal" | ||
gem "bump" | ||
gem "csv" | ||
gem "nokogiri" | ||
gem "pry-byebug" | ||
gem "rspec" | ||
gem "sequel" | ||
gem "sqlite3", "~> 1.7.0" | ||
gem "rails", "~> 7.0.0" | ||
|
||
group :mongo do | ||
gem "bson" | ||
gem "mongoid", "~> 9.0" | ||
end | ||
end | ||
|
||
gemspec path: "../" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
group :development do | ||
gem "appraisal" | ||
gem "bump" | ||
gem "csv" | ||
gem "nokogiri" | ||
gem "pry-byebug" | ||
gem "rspec" | ||
gem "sequel" | ||
gem "sqlite3", "~> 1.7.0" | ||
gem "rails", "~> 7.1.0" | ||
|
||
group :mongo do | ||
gem "bson" | ||
gem "mongoid", "~> 9.0" | ||
end | ||
end | ||
|
||
gemspec path: "../" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
# This file was generated by Appraisal | ||
|
||
source "https://rubygems.org" | ||
|
||
group :development do | ||
gem "appraisal" | ||
gem "bump" | ||
gem "csv" | ||
gem "nokogiri" | ||
gem "pry-byebug" | ||
gem "rspec" | ||
gem "sequel" | ||
gem "sqlite3", "~> 2.0.0" | ||
gem "rails", "~> 7.2.0" | ||
|
||
group :mongo do | ||
gem "bson" | ||
gem "mongoid", github: "mongodb/mongoid" | ||
end | ||
end | ||
|
||
gemspec path: "../" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there any particular reason to drop
6.0
support?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve removed support for Rails 6.0 as tests are failing on this version. Although the test build was showing as green, it was actually running on Rails 6.1 instead of 6.0. This happened because the Gemfile used
~> 6.0
, which incorrectly installed Rails 6.1. To truly use Rails 6.0, the Gemfile should have specified~> 6.0.0
.I chose not to reintroduce these hacks, and instead, I believe it’s time to officially drop support for this long end-of-life Rails version.
Here’s a screenshot for reference: