Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search & more! #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kelly-dance
Copy link

Added a few command-line options.

-v to show the joke id
--id [id] to fetch a specific joke
search [term] --page [page = 1] --limit [limit = 20] to search for jokes

also switched from request to node-fetch

@bobbyearl
Copy link
Owner

What an awesome PR from a repo I forgot even existed @mcbobby123!

There are some code-style changes I would like to keep in place. Given this is the first PR to this repo and you and I have never worked together, would you prefer I leave that feedback for you or make the changes myself?

Thanks again though, really excited to see this repo updated and new functionality added!

@kelly-dance
Copy link
Author

Just let me know what code style changes should be made and I'll try fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants