Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust call to correct method for PlainDateTime.prototype.since #4096

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 25, 2024

This Pull Request is related to #4072.

I was doing some bug searching / fixing and noticed that the wrong method was being called in since.

Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,625 48,625 0
Passed 43,845 43,853 +8
Ignored 1,471 1,471 0
Failed 3,309 3,301 -8
Panics 0 0 0
Conformance 90.17% 90.19% +0.02%
Fixed tests (8):
test/built-ins/Temporal/PlainDateTime/prototype/until/inverse.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/round-relative-to-receiver.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/smallestunit-undefined.js (previously Failed)

@jedel1043 jedel1043 requested a review from a team December 25, 2024 06:00
@raskad raskad added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit 71c6e7b Dec 25, 2024
13 checks passed
@raskad raskad deleted the patch-pdt-since branch December 25, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants