Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more ZonedDateTime method implementations #4095

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Add more ZonedDateTime method implementations #4095

merged 3 commits into from
Dec 24, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Dec 23, 2024

This Pull Request is related to ongoing work for #4075.

It adds the below methods

  • Temporal.ZonedDateTime.compare
  • Temporal.prototype.withPlainTime
  • Temporal.prototype.withTimeZone
  • Temporal.prototype.withCalendar
  • Temporal.prototype.equals
  • Temporal.prototype.startOfDay
  • Temporal.prototype.toInstant
  • Temporal.prototype.toPlainDate
  • Temporal.prototype.toPlainTime
  • Temporal.prototype.toPlainDateTime

@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,625 48,625 0
Passed 43,616 43,845 +229
Ignored 1,471 1,471 0
Failed 3,538 3,309 -229
Panics 0 0 0
Conformance 89.70% 90.17% +0.47%
Fixed tests (246): 
test/intl402/Temporal/PlainDate/from/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDate/compare/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/equals/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/until/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/since/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/Duration/prototype/round/relativeto-infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/Duration/prototype/total/relativeto-infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/from/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/compare/disregards-calendar-if-exact-times-equal.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/compare/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/compare/exhaustive.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withTimeZone/preserves-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/equals/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/equals/different-calendar-not-equal.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/equals/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/toPlainDate/preserves-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withCalendar/calendar-case-insensitive.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withCalendar/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/withCalendar/basic.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/prototype/subtract/options-undefined.js (previously Failed)
test/intl402/Temporal/PlainYearMonth/prototype/add/options-undefined.js (previously Failed)
test/intl402/Temporal/PlainDateTime/from/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDateTime/compare/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/equals/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/until/infinity-throws-rangeerror.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/since/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/balance-smaller-units-basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/balance-smaller-units.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/balance-smaller-units-basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/balance-smaller-units.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/precision-exact-mathematical-values-2.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/precision-exact-mathematical-values-1.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-duration-precision-exact-numerical-values.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/precision-exact-mathematical-values-2.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/precision-exact-mathematical-values-1.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/argument-duration-precision-exact-numerical-values.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/from/negative-inifinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/from/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/duration-out-of-range-added-to-relativeto.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/largestunit-correct-rebalancing.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/result-out-of-range.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/with/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/precision-exact-mathematical-values.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/result-out-of-range-1.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/result-out-of-range-2.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/nanoseconds-is-number-max-safe-integer.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/precision-exact-mathematical-values.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/result-out-of-range-1.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/basic.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/result-out-of-range-2.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/nanoseconds-is-number-max-safe-integer.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/overflow-options.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-function-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-monthcode-month.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-ignores-incorrect-properties.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/compares-exact-time-not-clock-time.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-invalid-offset-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-timezone-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/basic.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/disregard-time-zone-ids-if-exact-times-are-equal.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/different-time-zone-not-equal.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-invalid-offset-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/constructed-from-equivalent-parameters-are-equal.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/different-instant-not-equal.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/casts-argument.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-timezone-normalize-offset-strings.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDateTime/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainTime/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/overflow.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/math-order-of-operations-subtract-constrain.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/constrain-when-ambiguous-result.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/symmetrical-wrt-negative-durations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/math-order-of-operations-subtract-none.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDate/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDate/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDate/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDate/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDate/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toPlainDate/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/startOfDay/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/startOfDay/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/startOfDay/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/startOfDay/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/startOfDay/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/startOfDay/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/cross-epoch.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/overflow.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/math-order-of-operations-add-constrain.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/constrain-when-ambiguous-result.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/symmetrical-wrt-negative-durations-in-time-part.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/add-duration.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/math-order-of-operations-add-none.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/order-of-operations.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/casts-argument.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toInstant/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toInstant/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toInstant/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toInstant/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toInstant/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toInstant/builtin.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/calendar-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/calendar-iso-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/negative-infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/order-of-operations.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/infinity-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-minus-sign.js (previously Failed)
Broken tests (17): 
test/built-ins/Temporal/PlainDate/from/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainDate/compare/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/equals/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/until/calendar-id-match.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/until/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/since/calendar-id-match.js (previously Passed)
test/built-ins/Temporal/PlainDate/prototype/since/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainTime/from/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainTime/compare/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/Duration/out-of-range.js (previously Passed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/missing-argument.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/from/argument-string-minus-sign.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-minus-sign.js (previously Passed)

@nekevss nekevss requested review from jasonwilliams, jedel1043 and a team December 24, 2024 00:44
@nekevss nekevss added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Dec 24, 2024
@nekevss nekevss requested a review from a team December 24, 2024 02:45
jedel1043
jedel1043 approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jedel1043 jedel1043 added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 68e6d49 Dec 24, 2024
13 checks passed
@jedel1043 jedel1043 deleted the impl-more-zdt-methods branch December 24, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @raskad @jedel1043