Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow local parameters if mapped arguments object is not used #4092

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow local parameters if mapped arguments object is not used #4092

wants to merge 1 commit into from

Conversation

raskad
Copy link
Member

@raskad raskad commented Dec 23, 2024

This Pull Request changes the following:

  • Allow local parmeters if mapped arguments object is not used
  • Add tests for scopes in boa_ast

@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 48,625 48,625 0
Passed 43,616 43,616 0
Ignored 1,471 1,471 0
Failed 3,538 3,538 0
Panics 0 0 0
Conformance 89.70% 89.70% 0.00%

@raskad raskad added this to the next-release milestone Dec 23, 2024
@raskad raskad added the ast Issue surrounding the abstract syntax tree label Dec 23, 2024
@raskad raskad requested a review from a team December 23, 2024 03:32
@jedel1043 jedel1043 changed the title Allow local parmeters if mapped arguments object is not used Allow local parameters if mapped arguments object is not used Dec 23, 2024
jedel1043
jedel1043 approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization!

@jedel1043 jedel1043 requested a review from a team December 23, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
ast Issue surrounding the abstract syntax tree
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
2 participants
@raskad @jedel1043