Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fjcvtzs instruction for ARMv8.3 target #4084

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

CrazyboyQCD
Copy link
Contributor

Closes #4062.

@CrazyboyQCD CrazyboyQCD changed the title Add fjcvtzs instrution for ARMv8.3 target Add fjcvtzs instruction for ARMv8.3 target Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.14%. Comparing base (6ddc2b4) to head (0ad66e7).
Report is 317 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4084      +/-   ##
==========================================
+ Coverage   47.24%   53.14%   +5.90%     
==========================================
  Files         476      484       +8     
  Lines       46892    48223    +1331     
==========================================
+ Hits        22154    25630    +3476     
+ Misses      24738    22593    -2145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jasonwilliams
Copy link
Member

This is very cool @CrazyboyQCD!

Do you have a way of testing this as I assume Github Actions don't have any arm runners

@CrazyboyQCD
Copy link
Contributor Author

Do you have a way of testing this as I assume Github Actions don't have any arm runners

aarch64-apple-darwin is the only one I found that has the jsconv feature, I am not sure if we could use cross to test this.

@CrazyboyQCD CrazyboyQCD marked this pull request as ready for review December 13, 2024 02:42
@nekevss nekevss requested a review from a team December 13, 2024 03:33
@nekevss nekevss added the performance Performance related changes and issues label Dec 13, 2024
Copy link
Contributor

@hansl hansl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does what it says, and I manually tested it on my Mac, checking both the unit tests and the test262 in debug and release, but also verifying that the outputted release ASM contained the instruction at the right place.

LGTM.

@hansl hansl enabled auto-merge December 13, 2024 04:01
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for looking into this @CrazyboyQCD

@hansl hansl added this pull request to the merge queue Dec 13, 2024
Merged via the queue into boa-dev:main with commit 6f2dca8 Dec 13, 2024
14 checks passed
@raskad raskad added this to the next-release milestone Dec 14, 2024
@CrazyboyQCD CrazyboyQCD deleted the fjcvtzs-instruction branch December 18, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance related changes and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FJCVTZS instruction for ARMv8.3 target
5 participants