-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fjcvtzs
instruction for ARMv8.3
target
#4084
Conversation
ARMv8.3
targetfjcvtzs
instruction for ARMv8.3
target
b8448db
to
c110c56
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4084 +/- ##
==========================================
+ Coverage 47.24% 53.14% +5.90%
==========================================
Files 476 484 +8
Lines 46892 48223 +1331
==========================================
+ Hits 22154 25630 +3476
+ Misses 24738 22593 -2145 ☔ View full report in Codecov by Sentry. |
This is very cool @CrazyboyQCD! Do you have a way of testing this as I assume Github Actions don't have any arm runners |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does what it says, and I manually tested it on my Mac, checking both the unit tests and the test262 in debug and release, but also verifying that the outputted release ASM contained the instruction at the right place.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for looking into this @CrazyboyQCD
Closes #4062.