Allow resizing of underlying ArrayBuffer from Rust #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4082 +/- ##
==========================================
+ Coverage 47.24% 53.77% +6.53%
==========================================
Files 476 485 +9
Lines 46892 48150 +1258
==========================================
+ Hits 22154 25895 +3741
+ Misses 24738 22255 -2483 ☔ View full report in Codecov by Sentry. |
|
Does it make sense to merge this after #4083 gets merged? I think it would be easier to rebase this than to rebase the other PR which is a lot bigger. |
|
Sure I'll wait for that PR to be merged then rebase this one. |
|
@jedel1043 Please review and ready for merge :) The other PR is back to draft for the moment. |
jedel1043
reviewed
Dec 19, 2024
nekevss
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an API that might truncate an
ArrayBufferpassed in (or make it bigger). I have to callresize()from Rust for a buffer passed by JavaScript, and this is the best way I found to do that.