Build out Temporal's `ZonedDateTime` and `Now` #4068

nekevss · 2024-12-07T06:34:30Z

This Pull Request is related to the ongoing work for #1804

It changes the following:

Switches Boa to the most recent revision of temporal_rs
Adds a tz_provider field to Context using FsTzdbProvider to provide initial time zone support
Builds out the some of the initial accessor properties and some methods for ZonedDateTime
Builds out a couple methods for Now

github-actions · 2024-12-07T06:42:21Z

Test262 conformance changes

Test result	main count	PR count	difference
Total	48,494	48,625	+131
Passed	43,680	43,584	-96
Ignored	1,500	1,471	-29
Failed	3,314	3,570	+256
Panics	0	0	0
Conformance	90.07%	89.63%	-0.44%

Fixed tests (185):

test/intl402/Temporal/ZonedDateTime/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/legacy-non-iana.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/from/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/toLocaleString/time-zone-canonicalized.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/era/branding.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/era/prop-desc.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/eraYear/branding.js (previously Failed)
test/intl402/Temporal/ZonedDateTime/prototype/eraYear/prop-desc.js (previously Failed)
test/intl402/Intl/DateTimeFormat/prototype/formatRange/fails-on-distinct-temporal-types.js (previously Failed)
test/intl402/Intl/DateTimeFormat/prototype/formatRangeToParts/fails-on-distinct-temporal-types.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/observable-get-overflow-argument-primitive.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/observable-get-overflow-argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/from/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/equals/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/Instant/compare/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/order-of-operations.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/return-value-calendar.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/length.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-string.js (previously Failed)
test/built-ins/Temporal/Now/plainDateTimeISO/timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/Now/instant/return-value-instance.js (previously Failed)
test/built-ins/Temporal/Now/instant/return-value-value.js (previously Failed)
test/built-ins/Temporal/Now/instant/return-value-prototype.js (previously Failed)
test/built-ins/Temporal/Now/instant/return-value-distinct.js (previously Failed)
test/built-ins/Temporal/Now/zonedDateTimeISO/length.js (previously Failed)
test/built-ins/Temporal/Now/plainDateISO/length.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/options-object.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/fields-missing-properties.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/overflow.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/fields-leap-day.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/basic.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainMonthDay/from/fields-object.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/missing-arguments.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/calendar-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/calendar-number.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/timezone-iso-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/offset-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/offset-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-timezone-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-invalid-offset-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-case-insensitive.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/disambiguation-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-propertybag-calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/compare/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/microsecond/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/microsecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/microsecond/negative-epochnanoseconds.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInYear/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInYear/basic.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/monthCode/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/monthCode/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toLocaleString/return-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/round/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/timeZoneId/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/timeZoneId/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/dayOfYear/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/dayOfYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/inLeapYear/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/inLeapYear/basic.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/inLeapYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInMonth/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInMonth/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/hour/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/hour/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/hour/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/equals/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/monthsInYear/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/monthsInYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withPlainTime/argument-number.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/month/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/month/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/second/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/second/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/second/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/yearOfWeek/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/yearOfWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInWeek/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/daysInWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/nanosecond/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/nanosecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/argument-invalid-property.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/argument-mixed-sign.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/options-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/non-integer-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/argument-singular-properties.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/day/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/day/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/day/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/calendarId/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/calendarId/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/millisecond/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/millisecond/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/millisecond/negative-epochnanoseconds.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/options-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/getTimeZoneTransition/wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/year/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/year/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/calendar-number.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withCalendar/missing-argument.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/hoursInDay/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/hoursInDay/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/minute/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/minute/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/minute/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/name.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/length.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/argument-invalid-property.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/argument-mixed-sign.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/options-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/non-integer-throws-rangeerror.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/builtin.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/argument-singular-properties.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/toString/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/weekOfYear/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/weekOfYear/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/dayOfWeek/branding.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/dayOfWeek/prop-desc.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/argument-propertybag-calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/observable-get-overflow-argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/observable-get-overflow-argument-primitive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/overflow-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/with/calendar-temporal-object-throws.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/calendar-temporal-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/calendar-temporal-object.js (previously Failed)

Broken tests (129):

test/built-ins/Temporal/PlainTime/from/options-wrong-type.js (previously Passed)
test/built-ins/Temporal/PlainTime/from/overflow-wrong-type.js (previously Passed)
test/built-ins/Temporal/PlainTime/from/overflow-invalid-string.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/from/options-wrong-type.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/from/monthcode-invalid.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/from/observable-get-overflow-argument-primitive.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/from/observable-get-overflow-argument-string-invalid.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/from/order-of-operations.js (previously Passed)
test/built-ins/Temporal/PlainMonthDay/prototype/with/options-wrong-type.js (previously Passed)
test/built-ins/Temporal/ZonedDateTime/from/options-wrong-type.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/options-wrong-type.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-calendar-field.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-timezone-field.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/branding.js (previously Passed)
test/built-ins/Temporal/PlainYearMonth/prototype/with/argument-missing-fields.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/from/options-wrong-type.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Changes_When_Casemapped.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Balinese.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Kaithi.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Mahajani.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Balinese.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Caucasian_Albanian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Shavian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Carian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Dash.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Gothic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Kawi.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Cyrillic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Terminal_Punctuation.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Number.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Latin.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tai_Le.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Duployan.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Bidi_Mirrored.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tangut.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Greek.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Uppercase.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Kannada.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Osage.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Adlam.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Latin.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Case_Ignorable.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Myanmar.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Symbol.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Diacritic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Spacing_Mark.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Runic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Gunjala_Gondi.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Ideographic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Punctuation.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Coptic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/XID_Continue.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Lisu.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Nonspacing_Mark.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Myanmar.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Emoji_Presentation.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Math_Symbol.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Changes_When_NFKC_Casefolded.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tibetan.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Egyptian_Hieroglyphs.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Modifier_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Grapheme_Extend.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Samaritan.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Other_Punctuation.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Han.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Khitan_Small_Script.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Decimal_Number.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Armenian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Changes_When_Lowercased.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Georgian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Cherokee.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Dash_Punctuation.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Unassigned.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Cyrillic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Mongolian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Bengali.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Common.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Common.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Ethiopic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Math.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Symbol.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Syriac.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Uppercase_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Old_Turkic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Katakana.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Phags_Pa.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Hebrew.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Extender.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Thai.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Sentence_Terminal.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Lowercase_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Changes_When_Titlecased.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Khitan_Small_Script.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Lydian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Lycian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Changes_When_Uppercased.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Cased.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Changes_When_Casefolded.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Mark.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Tifinagh.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Grapheme_Base.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Kawi.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Lowercase.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Avestan.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Emoji.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Egyptian_Hieroglyphs.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/ID_Continue.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Glagolitic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/XID_Start.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Elbasan.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Old_Hungarian.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/General_Category_-_Cased_Letter.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Old_Permic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/ID_Start.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Alphabetic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Meroitic_Hieroglyphs.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Bopomofo.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Devanagari.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Assigned.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Toto.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_-_Arabic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Inherited.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/Script_Extensions_-_Arabic.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Flag_Sequence.js (previously Passed)
test/built-ins/RegExp/property-escapes/generated/strings/Basic_Emoji.js (previously Passed)

nekevss · 2024-12-07T06:54:42Z

Opened a PR to hopefully fix the compilation issues of this PR in boa-dev/temporal#125

…_os (#125) This PR is meant to address issues with boa-dev/boa#4068, which breaks when compiling for WASM targets. The changes were not made to the tests as I don't believe those will affect compilation. As a side note, we should probably be testing `temporal_rs` on more targets in CI if possible, especially with adding a FFI on the horizon.

jedel1043 · 2024-12-07T23:53:50Z

Nice! Did you investigate the test regressions we have?

nekevss · 2024-12-08T00:06:16Z

I didn't dig too deep into test regression as I'm fairly certain glancing at the broken tests that they were more so false positives beforehand. But I can definitely double check.

EDIT: huh, actually I'm going to dig into those more. The limit tests failing are interesting.

nekevss · 2024-12-08T00:55:28Z

Fixed the zonedDateTimeISO misspelled name. The other tests are probably somehow a regression in temporal_rs. Although, at a quick glance, I don't think this code was updated over the last few PRs, but I have to double check.

jedel1043 · 2024-12-08T01:57:19Z

I'd also suggest updating the test262 commit, since I think some tests could have been adjusted since our last bump.

nekevss · 2024-12-08T03:47:14Z

So after looking at it, I'm fairly certain the remaining broken tests (prior to the test262 bump) are definitely something broken, but it's most likely a break in temporal_rs and not from any specific to changes from this PR. I'm planning on looking into it and fixing it on the temporal_rs side asap.

…en down from test262

jedel1043

Looks good! We'll have to investigate the regexp tests, but since this didn't touch anything related, they must be updates of old tests.

nekevss added 2 commits December 5, 2024 22:07

Progress on implementing more of zdt

301a312

Complete build out of ZonedDateTime and Now

752bfdc

nekevss mentioned this pull request Dec 7, 2024

Adjust compilation configuration of tzdb to target_family from target_os boa-dev/temporal#125

Merged

nekevss requested review from jasonwilliams and jedel1043 December 7, 2024 06:54

Update temporal to fixed version

5703622

nekevss added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Dec 7, 2024

zonedDateTime -> zonedDateTimeISO

5082e81

Bump test262 commit

1fdb60c

nekevss added 8 commits December 7, 2024 21:51

Add import-defer to ignore list

7cca60d

Add import-defer to feature edition

cbe27c3

Add other adjustments for test262 bump

738eab2

Remove expects from month-day to address panics

0b45446

Fix panics with Date object

d250da9

Missed one of the clippy lints

133478e

Adjustments to address some broken tests + added PlainDate tests brok…

a3dc6ac

…en down from test262

Bump temporal_rs to bug fixed version

88d5470

jedel1043 approved these changes Dec 9, 2024

View reviewed changes

jedel1043 requested a review from a team December 9, 2024 00:23

Update get_options_object order of operations

1265a08

raskad approved these changes Dec 11, 2024

View reviewed changes

raskad added this pull request to the merge queue Dec 11, 2024

Merged via the queue into main with commit 934546e Dec 11, 2024
13 checks passed

raskad deleted the impl-temporal-zoneddatetime branch December 11, 2024 19:13

raskad added this to the next-release milestone Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build out Temporal's `ZonedDateTime` and `Now` #4068

Build out Temporal's `ZonedDateTime` and `Now` #4068

nekevss commented Dec 7, 2024

github-actions bot commented Dec 7, 2024 •

edited

Loading

nekevss commented Dec 7, 2024

jedel1043 commented Dec 7, 2024

nekevss commented Dec 8, 2024 •

edited

Loading

nekevss commented Dec 8, 2024

jedel1043 commented Dec 8, 2024

nekevss commented Dec 8, 2024 •

edited

Loading

jedel1043 left a comment

Build out Temporal's ZonedDateTime and Now #4068

Build out Temporal's ZonedDateTime and Now #4068

Conversation

nekevss commented Dec 7, 2024

github-actions bot commented Dec 7, 2024 • edited Loading

Test262 conformance changes

nekevss commented Dec 7, 2024

jedel1043 commented Dec 7, 2024

nekevss commented Dec 8, 2024 • edited Loading

nekevss commented Dec 8, 2024

jedel1043 commented Dec 8, 2024

nekevss commented Dec 8, 2024 • edited Loading

jedel1043 left a comment

Choose a reason for hiding this comment

Build out Temporal's `ZonedDateTime` and `Now` #4068

Build out Temporal's `ZonedDateTime` and `Now` #4068

github-actions bot commented Dec 7, 2024 •

edited

Loading

nekevss commented Dec 8, 2024 •

edited

Loading

nekevss commented Dec 8, 2024 •

edited

Loading