update Boa to be inline with Temporal #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4034 +/- ##
==========================================
+ Coverage 47.24% 53.14% +5.90%
==========================================
Files 476 484 +8
Lines 46892 47735 +843
==========================================
+ Hits 22154 25371 +3217
+ Misses 24738 22364 -2374 ☔ View full report in Codecov by Sentry. |
nekevss
approved these changes
Nov 11, 2024
jasonwilliams
force-pushed
the
update_temporal
branch
from
030131c to
57b8c46
Compare
|
@nekevss i've cleaned up the comments and rebased, ill look at zonedDateTime in a follow up PR |
jedel1043
reviewed
Nov 19, 2024
jasonwilliams
added a commit
to boa-dev/temporal
that referenced
this pull request
Nov 26, 2024
- md_record from parse_ixdtf is enough, we shouldn't need to fall back to datetime parsing. - from_str should lowercase the iso8601 (fixes tests) - Support parsing the ISO string then getting the calendar from that. - Support ref year This is to support changes in boa-dev/boa#4034
nekevss
reviewed
Nov 27, 2024
jasonwilliams
force-pushed
the
update_temporal
branch
from
7d68c3c to
b01bf93
Compare
jedel1043
reviewed
Dec 5, 2024
Comment on lines
+317
to
+345
| let day = item | ||
| .get_v(js_string!("day"), context) | ||
| .expect("Day not found") | ||
| .to_i32(context) | ||
| .expect("Cannot convert day to i32"); | ||
| let month = item | ||
| .get_v(js_string!("month"), context) | ||
| .expect("Month not found") | ||
| .to_i32(context) | ||
| .expect("Cannot convert month to i32"); | ||
|
|
||
| let month_code = item | ||
| .get_v(js_string!("monthCode"), context) | ||
| .expect("monthCode not found"); | ||
| let resolved_month_code = if month_code.is_undefined() { | ||
| None | ||
| } else { | ||
| TinyAsciiStr::<4>::from_str( | ||
| &month_code | ||
| .to_string(context) | ||
| .expect("Cannot convert monthCode to string") | ||
| .to_std_string_escaped(), | ||
| ) | ||
| .map_err(|e| JsError::from(JsNativeError::range().with_message(e.to_string()))) | ||
| .ok() | ||
| }; | ||
| let year = item.get_v(js_string!("year"), context).map_or(1972, |val| { | ||
| val.to_i32(context).expect("Cannot convert year to i32") | ||
| }); |
There was a problem hiding this comment.
Thought: this was already here, but I'm a bit worried that we're just expecting a lot of missing values instead of throwing errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings Boa inline with the latest changes in Temporal