Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong neg operation #3926

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Fix wrong neg operation #3926

merged 3 commits into from
Jul 23, 2024

Conversation

CrazyboyQCD
Copy link
Contributor

@CrazyboyQCD CrazyboyQCD commented Jul 19, 2024 •
edited
Loading

Negative boolean and null should return negative value

@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.46%. Comparing base (6ddc2b4) to head (ae54e48).
Report is 217 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3926      +/-   ##
==========================================
+ Coverage   47.24%   51.46%   +4.21%     
==========================================
  Files         476      468       -8     
  Lines       46892    44989    -1903     
==========================================
+ Hits        22154    23153     +999     
+ Misses      24738    21836    -2902

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jedel1043
jedel1043 reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Can you add a test for it? Apparently test262 didn't have a test for this.

@CrazyboyQCD
Copy link
Contributor Author

Good catch! Can you add a test for it? Apparently test262 didn't have a test for this.

Done.

jedel1043
jedel1043 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jedel1043 jedel1043 added the bug Something isn't working label Jul 23, 2024
@jedel1043 jedel1043 added this to the next-release milestone Jul 23, 2024
@jedel1043 jedel1043 requested a review from a team July 23, 2024 00:57
HalidOdat
HalidOdat approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@HalidOdat HalidOdat added this pull request to the merge queue Jul 23, 2024
Merged via the queue into boa-dev:main with commit 6e6d67c Jul 23, 2024
14 checks passed
@CrazyboyQCD CrazyboyQCD deleted the fix_wrong_neg_operation branch July 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CrazyboyQCD @HalidOdat @jedel1043