Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement more Temporal functionality #3924

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Implement more Temporal functionality #3924

merged 7 commits into from
Jul 18, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 18, 2024 •
edited
Loading

This Pull Request makes updates for the ongoing work on Temporal.

It changes the following:

  • Moves main back to temporal_rs's git
  • Implements various methods (see below)

Methods implemented:

  • Duration.prototype.negated
  • PlainDate.prototype.fromCalendar
  • PlainDateTime.prototype.fromPlainTime
  • PlainDateTime.prototype.fromCalendar
  • PlainDateTime.prototype.until
  • PlainDateTime.prototype.since
  • PlainDateTime.prototype.equals
  • PlainDate.compare
  • PlainDateTime.compare
  • PlainTime.compare

Partially implements on Boa's side (not yet implemented in temporal_rs)

  • PlainDateTime.prototype.round

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Test262 conformance changes

Test result main count PR count difference
Total 48,212 48,212 0
Passed 42,875 43,151 +276
Ignored 1,413 1,413 0
Failed 3,924 3,648 -276
Panics 0 0 0
Conformance 88.93% 89.50% +0.57%
Fixed tests (284): 
test/intl402/Temporal/PlainDate/compare/exhaustive.js (previously Failed)
test/intl402/Temporal/PlainDate/prototype/withCalendar/canonicalize-calendar.js (previously Failed)
test/intl402/Temporal/PlainDateTime/compare/calendar-ignored.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/since/different-calendars-throws.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/until/different-calendars-throws.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/equals/calendar-checked.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/withCalendar/argument-string.js (previously Failed)
test/intl402/Temporal/PlainDateTime/prototype/withCalendar/canonicalize-calendar.js (previously Failed)
test/staging/Temporal/Regex/old/plaintime.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/use-internal-slots.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/basic.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/name.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/exhaustive.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/length.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainTime/compare/builtin.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/observable-get-overflow-argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-trailing-junk.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainTime/from/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/largestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/name.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/smallestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/branding.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/since/builtin.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/basic.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-ceil.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfFloor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfEven.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/largestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/name.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfExpand.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfTrunc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/smallestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/options-object.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-expand.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-halfCeil.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingmode-floor.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/round-cross-unit-boundary.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/branding.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/until/builtin.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/valueOf/basic.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/basic.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/equals/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/round/roundingincrement-invalid.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/negated/branding.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-ceil.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfFloor.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfEven.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfExpand.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfTrunc.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-expand.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-halfCeil.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/round/roundingmode-floor.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/use-internal-slots.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-multiple-calendar.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/name.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-plaindatetime.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/length.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/not-same-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/compare/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/basic.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-number.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/withCalendar/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/use-internal-slots.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/exhaustive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-cleanly-divides.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/largestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/options-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-cleanly-divides.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/balance-negative-duration.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/round-relative-to-receiver.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/smallestunit-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/weeks-months-mutually-exclusive.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/options-empty.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-undefined.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/smallestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/largestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-plaindate.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-date-with-utc-offset.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-critical-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-calendar-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-calendar-annotation-invalid-key.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/year-zero.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-time-zone-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-with-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-minus-sign.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-without-time-designator.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-time-separators.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-no-implicit-midnight.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-time.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-unknown-annotation.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/argument-string-multiple-time-zone.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withPlainTime/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object-insufficient-data.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-nan.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundto-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingmode-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/smallestunit-invalid-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/throws-argument-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-does-not-divide.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/roundingincrement-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/builtin.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/basic.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/not-a-constructor.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/name.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-string.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/calendar-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/length.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/subclassing-ignored.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/prop-desc.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/branding.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/builtin.js (previously Failed)
Broken tests (8): 
test/built-ins/Temporal/PlainDate/compare/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-object-insufficient-data.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/compare/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-object-insufficient-data.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-propertybag-calendar-number.js (previously Passed)
test/built-ins/Temporal/PlainDateTime/prototype/withCalendar/missing-argument.js (previously Passed)

@nekevss nekevss requested a review from a team July 18, 2024 00:55
@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Jul 18, 2024
@jedel1043 jedel1043 added this to the next-release milestone Jul 18, 2024
@jedel1043
Copy link
Member

jedel1043 commented Jul 18, 2024 •
edited
Loading

Were those broken tests false positives before?

@nekevss
Copy link
Member Author

nekevss commented Jul 18, 2024 •
edited
Loading

Yeah, the broken tests should be false positives as they weren't implemented prior to then.

EDIT: add some compare methods and bumped temporal_rs. This PR should bring us up to ~32% conformance on the Temporal suite

EDIT 2: 8 Broken tests now, but all of them should be false positives as the methods weren't implemented prior.

jedel1043
jedel1043 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Most of the important changes were already reviewed in temporal_rs, so this is pretty much good.

@raskad raskad added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 7d025bc Jul 18, 2024
13 checks passed
@nekevss nekevss deleted the more-temporal-implementations branch July 19, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@raskad raskad raskad approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @jedel1043 @raskad