Add a js_error! macro to create opaque errors #3920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And as a bonus since I needed it, simplify comparison of strings and add PartialEq<&str> for JsString.
jedel1043
reviewed
Jul 16, 2024
jedel1043
reviewed
Jul 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3920 +/- ##
==========================================
+ Coverage 47.24% 51.52% +4.28%
==========================================
Files 476 467 -9
Lines 46892 44803 -2089
==========================================
+ Hits 22154 23085 +931
+ Misses 24738 21718 -3020 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And as a bonus since I needed it, simplify comparison of strings and add PartialEq<&str> for JsString.