Fix various parser idempotency issues and parsing errors #3917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of parser idempotency issues, but also some parsing errors where our parser was behaving non spec compliant. I found all of the issues via the
parser-idempotency
fuzzer.There are a lot of changes here regarding the names of function expressions and their handling via
has_binding_identifier
. Since there are some more issues with that, I plan to alter our current handling to fix those and align the handling more with the spec in a follow up to this.It changes the following:
Literal::Undefined
from being constructed byArbitrary
as it is only used for optimizationsLiteral::BigInt
formattingArbitrary
implementation forTemplateLiteral
throw
statementTaggedTemplate