-
-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly resolve paths in SimpleModuleLoader and add path to Referrer::Script #3791
Conversation
Note: This should fix many test262 that were broken by the last changes to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3791 +/- ##
==========================================
+ Coverage 47.24% 50.23% +2.98%
==========================================
Files 476 456 -20
Lines 46892 44816 -2076
==========================================
+ Hits 22154 22513 +359
+ Misses 24738 22303 -2435 ☔ View full report in Codecov by Sentry. |
Test262 conformance changes
Broken tests (20):
|
By the way, this doesn't print a nice comment because the action doesn't work on forks. If you want to see the test count, you can check it on the test262 action: Specifically on the input of the "Write a new comment" task. |
Fixed the remaining tests. This now just needs some small fixes on the tests and docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! :)
}, | ||
{ | ||
"type": "lldb", | ||
"request": "launch", | ||
"name": "Debug Boa (Tester)", | ||
"windows": { | ||
"program": "${workspaceFolder}/target/debug/boa_tester.exe" | ||
}, | ||
"program": "${workspaceFolder}/target/debug/boa_tester", | ||
"args": ["run", "-s", "${input:testPath}", "-vvv"], | ||
"sourceLanguages": ["rust"], | ||
"preLaunchTask": "Cargo Build boa_tester" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition! :)
We do have the path in parsed
Script
(if theSource
has it), so use that if we can.Fixes #3790.