Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal: Initial PlainTime build out #3621

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Temporal: Initial PlainTime build out #3621

merged 1 commit into from
Jan 31, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 29, 2024

This Pull Request is related to ongoing work for #1804.

Primarily plugs some of the implemented boa_temporal's Time into PlainTime in the

It changes the following:

  • Adds PlainTime accessors and some methods
  • Implements to_temporal_duration_record

@nekevss nekevss force-pushed the temporal-time-builtin branch from b02afb7 to 67c8359 Compare January 29, 2024 00:52
@nekevss nekevss added this to the v0.18.0 milestone Jan 29, 2024
@nekevss nekevss added builtins PRs and Issues related to builtins/intrinsics waiting-on-review Waiting on reviews from the maintainers labels Jan 29, 2024
@nekevss nekevss requested a review from a team January 29, 2024 00:56
@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,596 76,596 0
Ignored 18,477 18,477 0
Failed 887 887 0
Panics 0 0 0
Conformance 79.82% 79.82% 0.00%

raskad
raskad approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@raskad raskad requested a review from a team January 29, 2024 21:30
HalidOdat
HalidOdat reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat enabled auto-merge January 30, 2024 09:55
@raskad
Copy link
Member

raskad commented Jan 30, 2024

Looks good to me! :)

@HalidOdat You only commented and not approved ;)

HalidOdat
HalidOdat approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HalidOdat You only commented and not approved ;)

Sorry, I meant to approve it 😆

@HalidOdat HalidOdat added this pull request to the merge queue Jan 31, 2024
Merged via the queue into main with commit bb9d692 Jan 31, 2024
13 checks passed
@HalidOdat HalidOdat deleted the temporal-time-builtin branch January 31, 2024 06:50
@HalidOdat HalidOdat mentioned this pull request Feb 28, 2024
Merged
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nekevss @raskad @HalidOdat @jedel1043