-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporal Instant
migration cont. and related changes
#3601
Conversation
Test262 conformance changes
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3601 +/- ##
==========================================
+ Coverage 47.35% 47.46% +0.10%
==========================================
Files 475 475
Lines 45919 45817 -102
==========================================
+ Hits 21746 21748 +2
+ Misses 24173 24069 -104 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just have one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! :)
This Pull Request related to ongoing work around #1804. This continues the work on migrating
Temporal
functionality inboa_temporal
.It changes the following:
Instant
methodsadd
,subtract
,round
,until
, andsince
toboa_temporal