Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DifferenceInstant and related refactor #3568

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 7, 2024

This Pull Request is related to #1804.

This PR implements the abstract operation DifferenceInstant (diff_instant) on Instant. There was a refactor also made to Duration as a result.

It changes the following:

  • Separates TimeDuration and DateDuration from Duration.
  • Adjustments to various Duration methods to account for the above (the most "radical" being to round)

@nekevss nekevss force-pushed the temporal-instant-diff branch from 7d2db65 to d729a59 Compare January 7, 2024 17:31
Copy link

github-actions bot commented Jan 7, 2024

Test262 conformance changes

Test result main count PR count difference
Total 95,960 95,960 0
Passed 76,558 76,558 0
Ignored 18,477 18,477 0
Failed 925 925 0
Panics 0 0 0
Conformance 79.78% 79.78% 0.00%

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 403 lines in your changes are missing coverage. Please review.

Comparison is base (6c5dfe0) 47.34% compared to head (d729a59) 47.33%.

Files Patch % Lines
core/temporal/src/components/duration/time.rs 19.02% 166 Missing ⚠️
core/temporal/src/components/duration/date.rs 17.21% 125 Missing ⚠️
core/temporal/src/components/duration.rs 17.34% 81 Missing ⚠️
core/temporal/src/components/instant.rs 0.00% 23 Missing ⚠️
core/temporal/src/components/date.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3568      +/-   ##
==========================================
- Coverage   47.34%   47.33%   -0.01%     
==========================================
  Files         473      475       +2     
  Lines       45682    45800     +118     
==========================================
+ Hits        21627    21679      +52     
- Misses      24055    24121      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss added this to the v0.18.0 milestone Jan 7, 2024
@nekevss nekevss added technical debt builtins PRs and Issues related to builtins/intrinsics labels Jan 7, 2024
@nekevss nekevss requested a review from a team January 7, 2024 17:46
@nekevss nekevss added the waiting-on-review Waiting on reviews from the maintainers label Jan 7, 2024
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nekevss nekevss requested a review from a team January 9, 2024 23:22
@raskad raskad added this pull request to the merge queue Jan 16, 2024
Merged via the queue into main with commit d71334e Jan 16, 2024
14 checks passed
@jedel1043 jedel1043 deleted the temporal-instant-diff branch January 16, 2024 18:43
@jedel1043 jedel1043 removed the waiting-on-review Waiting on reviews from the maintainers label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants