-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ISO8601
parsing to boa_temporal
#3500
Conversation
a9277fa
to
7c52efa
Compare
Test262 conformance changes
|
7c52efa
to
21bc6fb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
==========================================
+ Coverage 45.27% 46.42% +1.14%
==========================================
Files 496 496
Lines 50810 50775 -35
==========================================
+ Hits 23006 23570 +564
+ Misses 27804 27205 -599 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a straightforward migration. Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
Continuation of the
boa_temporal
migration.Relates tangentially to #1804
It changes the following:
Temporal
parts fromboa_ast
andboa_parser
intoboa_temporal
FromStr
integration forDateTime
andDate
.