Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress on Duration's round/total method updates #3451

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Progress on Duration's round/total method updates #3451

merged 4 commits into from
Nov 7, 2023

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Nov 3, 2023

Follow up to #3443.

Just looking to merge more progress on some Duration methods. 😄

Let me know what you think!

@nekevss nekevss added the builtins PRs and Issues related to builtins/intrinsics label Nov 3, 2023
@nekevss nekevss changed the base branch from temporal-cleanup-one to main November 4, 2023 00:44
@nekevss nekevss force-pushed the duration-round-total branch 2 times, most recently from a0b6286 to e3535d8 Compare November 4, 2023 01:02
@nekevss nekevss force-pushed the duration-round-total branch from e3535d8 to 5a05ca1 Compare November 4, 2023 01:02
@codecov Codecov
Copy link

codecov bot commented Nov 4, 2023 •
edited
Loading

Codecov Report

Attention: 249 lines in your changes are missing coverage. Please review.

Comparison is base (34d5c51) 44.81% compared to head (cf80db4) 44.67%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3451      +/-   ##
==========================================
- Coverage   44.81%   44.67%   -0.15%     
==========================================
  Files         488      488              
  Lines       50373    50513     +140     
==========================================
- Hits        22576    22567       -9     
- Misses      27797    27946     +149
Files Coverage Δ
boa_engine/src/builtins/temporal/options.rs 0.00% <0.00%> (ø)
boa_engine/src/builtins/temporal/mod.rs 26.78% <0.00%> (ø)
boa_engine/src/builtins/temporal/instant/mod.rs 12.11% <0.00%> (-0.04%) ⬇️
boa_engine/src/builtins/temporal/duration/mod.rs 35.20% <0.00%> (-3.89%) ⬇️
...oa_engine/src/builtins/temporal/duration/record.rs 7.71% <0.00%> (-1.21%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 76,518 76,518 0
Ignored 18,132 18,132 0
Failed 959 959 0
Panics 0 0 0
Conformance 80.03% 80.03% 0.00%

@nekevss nekevss requested a review from a team November 4, 2023 01:57
HalidOdat
HalidOdat approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@HalidOdat HalidOdat modified the milestones: v0.19.0, v0.18.0 Nov 5, 2023
@HalidOdat HalidOdat requested a review from a team November 5, 2023 14:32
jedel1043
jedel1043 reviewed Nov 6, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress! Just have a small suggestion.

boa_engine/src/builtins/temporal/duration/mod.rs Outdated Show resolved Hide resolved
jedel1043
jedel1043 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more nitpicks :) Great work!

@jedel1043 jedel1043 enabled auto-merge November 7, 2023 01:23
@jedel1043 jedel1043 added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit f551af9 Nov 7, 2023
14 checks passed
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
@nekevss @ahaoboy
Progress on Duration's round/total method updates (boa-dev#3451)
6651447 
* Update round and total method

* Apply review

* Cargo fmt

* validate rounding increment to u64
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
@nekevss @ahaoboy
Progress on Duration's round/total method updates (boa-dev#3451)
c8c752c 
* Update round and total method

* Apply review

* Cargo fmt

* validate rounding increment to u64
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
@nekevss @sam-finch-tezos
Progress on Duration's round/total method updates (boa-dev#3451)
fc7cf32 
* Update round and total method

* Apply review

* Cargo fmt

* validate rounding increment to u64
@raskad raskad deleted the duration-round-total branch December 5, 2023 12:15
@HalidOdat HalidOdat mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedel1043 jedel1043 jedel1043 approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nekevss @HalidOdat @jedel1043