Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump icu_datagen from 1.3.2 to 1.3.3 #3437

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 30, 2023

Bumps icu_datagen from 1.3.2 to 1.3.3.

Changelog

Sourced from icu_datagen's changelog.

icu4x 1.3.3 (later Oct, 2023)

Some crates received a 1.3.3 patch release:

  • [Fix #4165, locale "vi" not working in Collator](unicode-org/icu4x#4165):
    • icu_collator
    • icu_collator_data
  • [Fix #4232, some locale data being improperly deduplicated](unicode-org/icu4x#4232):
    • icu_compactdecimal_data
    • icu_datagen
    • icu_datetime_data
    • icu_decimal_data
    • icu_displaynames_data
    • icu_properties_data
Commits
  • acd0205 Update version numbers of selected crates to 1.3.3 (#4233)
  • 7d78aa3 Copy changelog from main to release/1.3
  • 3e4b1ee Fix datagen deduplication algorithm. Create and update tests. (#4233)
  • b70528d Update icu_collator dependency version on icu_collator_data to 1.3.3
  • 82b0f86 Update icu_collator[_data] to 1.3.3
  • 412cbb7 cargo make bakeddata components/collator
  • eb458ab cargo make testdata
  • 81beb47 Make CollationDiacriticsV1Marker not be singleton
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [icu_datagen](https://github.com/unicode-org/icu4x) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/unicode-org/icu4x/releases)
- [Changelog](https://github.com/unicode-org/icu4x/blob/main/CHANGELOG.md)
- [Commits](https://github.com/unicode-org/icu4x/compare/[email protected]/[email protected])

---
updated-dependencies:
- dependency-name: icu_datagen
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 30, 2023
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll probably require a datagen run.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e89c4e) 45.40% compared to head (27c4fdb) 45.39%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3437      +/-   ##
==========================================
- Coverage   45.40%   45.39%   -0.02%     
==========================================
  Files         483      483              
  Lines       49790    49787       -3     
==========================================
- Hits        22609    22602       -7     
- Misses      27181    27185       +4     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,609 95,609 0
Passed 75,978 75,978 0
Ignored 18,872 18,872 0
Failed 759 759 0
Panics 0 0 0
Conformance 79.47% 79.47% 0.00%

@jedel1043 jedel1043 requested a review from a team October 30, 2023 18:54
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@raskad raskad added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 2f1fef2 Oct 30, 2023
14 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/icu_datagen-1.3.3 branch October 30, 2023 19:29
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
* Bump icu_datagen from 1.3.2 to 1.3.3

Bumps [icu_datagen](https://github.com/unicode-org/icu4x) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/unicode-org/icu4x/releases)
- [Changelog](https://github.com/unicode-org/icu4x/blob/main/CHANGELOG.md)
- [Commits](https://github.com/unicode-org/icu4x/compare/[email protected]/[email protected])

---
updated-dependencies:
- dependency-name: icu_datagen
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Regenerate data

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jedel1043 <[email protected]>
ahaoboy pushed a commit to ahaoboy/boa that referenced this pull request Nov 15, 2023
* Bump icu_datagen from 1.3.2 to 1.3.3

Bumps [icu_datagen](https://github.com/unicode-org/icu4x) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/unicode-org/icu4x/releases)
- [Changelog](https://github.com/unicode-org/icu4x/blob/main/CHANGELOG.md)
- [Commits](https://github.com/unicode-org/icu4x/compare/[email protected]/[email protected])

---
updated-dependencies:
- dependency-name: icu_datagen
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Regenerate data

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jedel1043 <[email protected]>
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
* Bump icu_datagen from 1.3.2 to 1.3.3

Bumps [icu_datagen](https://github.com/unicode-org/icu4x) from 1.3.2 to 1.3.3.
- [Release notes](https://github.com/unicode-org/icu4x/releases)
- [Changelog](https://github.com/unicode-org/icu4x/blob/main/CHANGELOG.md)
- [Commits](https://github.com/unicode-org/icu4x/compare/[email protected]/[email protected])

---
updated-dependencies:
- dependency-name: icu_datagen
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Regenerate data

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jedel1043 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants