Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate all parts of class in strict mode #3383

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

HalidOdat
Copy link
Member

11.2.2 Strict Mode Code

  • All parts of a ClassDeclaration or a ClassExpression are strict mode code.

[11.2.2 Strict Mode Code](https://tc39.es/ecma262/#sec-strict-mode-code)

- All parts of a `ClassDeclaration` or a `ClassExpression` are strict mode code.
@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Oct 13, 2023
@HalidOdat HalidOdat added this to the v0.18.0 milestone Oct 13, 2023
@HalidOdat HalidOdat requested a review from a team October 13, 2023 15:57
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 95,574 95,574 0
Passed 75,341 75,342 +1
Ignored 19,482 19,482 0
Failed 751 750 -1
Panics 0 0 0
Conformance 78.83% 78.83% +0.00%
Fixed tests (1):
test/language/statements/class/strict-mode/arguments-callee.js (previously Failed)

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f438ffa) 46.05% compared to head (4664c91) 46.06%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3383   +/-   ##
=======================================
  Coverage   46.05%   46.06%           
=======================================
  Files         474      474           
  Lines       48737    48740    +3     
=======================================
+ Hits        22447    22450    +3     
  Misses      26290    26290           
Files Coverage Δ
boa_engine/src/bytecompiler/class.rs 15.67% <100.00%> (+0.63%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raskad raskad requested a review from a team October 13, 2023 16:49
@raskad raskad added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 24c290a Oct 13, 2023
14 checks passed
@HalidOdat HalidOdat deleted the fix/evaluate-class-strict-mode branch October 13, 2023 18:40
sam-finch-tezos pushed a commit to trilitech/boa that referenced this pull request Nov 29, 2023
[11.2.2 Strict Mode Code](https://tc39.es/ecma262/#sec-strict-mode-code)

- All parts of a `ClassDeclaration` or a `ClassExpression` are strict mode code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants