Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compile time environment handling #3365

Merged
merged 3 commits into from
Oct 10, 2023

Apply review

e389020
Select commit
Loading
Failed to load commit list.
Merged

Refactor compile time environment handling #3365

Apply review
e389020
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 10, 2023 in 1s

49.49% (-0.06%) compared to 348c757

View this Pull Request on Codecov

49.49% (-0.06%) compared to 348c757

Details

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (348c757) 49.55% compared to head (e389020) 49.49%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3365      +/-   ##
==========================================
- Coverage   49.55%   49.49%   -0.06%     
==========================================
  Files         446      446              
  Lines       43705    43643      -62     
==========================================
- Hits        21656    21602      -54     
+ Misses      22049    22041       -8     
Files Coverage Δ
boa_engine/src/builtins/json/mod.rs 84.90% <100.00%> (+0.05%) ⬆️
boa_engine/src/bytecompiler/env.rs 100.00% <100.00%> (+5.12%) ⬆️
boa_engine/src/bytecompiler/expression/assign.rs 37.83% <100.00%> (-0.42%) ⬇️
boa_engine/src/bytecompiler/expression/unary.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/expression/update.rs 55.00% <100.00%> (-0.45%) ⬇️
boa_engine/src/bytecompiler/function.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/block.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/switch.rs 100.00% <100.00%> (ø)
boa_engine/src/bytecompiler/statement/try.rs 91.20% <100.00%> (+0.29%) ⬆️
boa_engine/src/bytecompiler/statement/with.rs 100.00% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.